[Webkit-unassigned] [Bug 23526] clipToImageBuffer() for all platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23526





--- Comment #32 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-02-23 03:26:51 PST ---
(In reply to comment #29)
> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1185
> > +    cairo_surface_t* currentTarget = cairo_get_target(cr);
> 
> This should be cairo_get_group_target(cr);
> cairo_get_target() will always reference the original surface that was passed to cairo_create(), not the one that's currently painted to.

I'm not sure why, but using cairo_get_group_target(cr) breaks the example attached in comment #10.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1199
> > +    cairo_set_source_surface(cr, currentContents.get(), rect.x(), rect.y());
> 
> You could just do cairo_set_source_surface(cr, currentTarget, rect.x(), rect.y()); here and avoid the whole currentContents surface, unless I'M not understanding why you do the currentContents thing.

indeed, we can use the current target here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.