[Webkit-unassigned] [Bug 49523] IME candidate characters inserted unexpectedly to textarea which listens compositionupdate event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49523





--- Comment #26 from jpu at apple.com  2011-02-22 23:02:01 PST ---
(In reply to comment #25)
> Jia, this bug deals with effects of a fix for <rdar://problem/6864072>, "Contraction base marked as misspelled even though contraction is a word." I don't know if there is any direct relation, but the symptoms are definitely similar.
> 
> Regardless of whether there is any relation, your comments about this bug would be appreciated. In particular, I'm not sure about potential effects a fix could have on Safari for Windows, as well as on older Mac OS X versions.

I added Doug to the CC list. He's the author of changeset 43419, and may want to add my comment below.

We'd recommend to use caution when removing "PLATFORM(MAC)". Looking at changeset 43419 alone can be misleading. Prior to changeset 42911 (http://trac.webkit.org/changeset/42911/trunk/WebCore/editing/TypingCommand.cpp), markMisspellingsAfterTyping() is called before appliedEditing() on all platforms. During Snow Leopard development, the order of these two calls are switched in changeset 42911. Upon realizing that the switching has caused regression, the preprocessor was added for Snow Leopard. In other words, appliedEditing() is called before markMisspellingAfterTyping() only on Snow Leopard. So what changeset 43419 does is simply making sure the behavior on non-SL platforms is what is used to be.

Given this history, it seems removing "PLATFORM(MAC)" will not change the order of these two function calls on older Mac OS X versions. But it will change the behavior on other platforms, including Safari for Windows. And the new behavior hasn't been exercised on those platforms before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.