[Webkit-unassigned] [Bug 54606] [Chromium] Control-Up/Down do not scroll by page on Chrome/Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54606


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82734|review?                     |review+
               Flag|                            |




--- Comment #3 from Shinichiro Hamaji <hamaji at chromium.org>  2011-02-22 21:19:42 PST ---
(From update of attachment 82734)
View in context: https://bugs.webkit.org/attachment.cgi?id=82734&action=review

r=me

I think you would want to set cq? when you ask a review for your patch.

> Source/WebKit/chromium/ChangeLog:5
> +        Control-Up/Down should be PageUp/Down on Mac.

I think it's nice to have prefixes for this kind of platform specific changes.

> Source/WebKit/chromium/src/WebViewImpl.cpp:809
> +    // Control-Up/Down should be PageUp/Downb on Mac.

s/Downb/Down/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.