[Webkit-unassigned] [Bug 54533] [NRWT] new-run-webkit-test should find DumpRenderTree even if 'ninja' is used as a build system.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54533





--- Comment #13 from Hayato Ito <hayato at chromium.org>  2011-02-22 19:15:54 PST ---
I am aware that we can use symlink out/{Debug, Release} to ninja. I am actually doing it and fully satisfied with 'symbolic link' solution. 
But it takes some time for me to find that solution. I just wanted other developers not to spend some time on finding such a solution. It is nice to use ninja out of box without such a tweaking.

I don't have a strong opinion that we should support ninja in new-run-webkit-test at this point. So review- is okay for me now until ninja becomes more popular and ready for prime time.

(In reply to comment #9)
> (In reply to comment #7)
> > (From update of attachment 82600 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=82600&action=review
> > 
> > adding evan to this. Evan, is ninja intentionally ignoring the configuration? That doesn't seem like a good thing.
> > 
> > > Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py:94
> > > +                    if arg.lower() not in ['release', 'debug', 'default']]
> > 
> > This is kind of an ugly hack. If it is correct that ninja ignores the configuration, then I think it would be better to change the signature of _build_path() to be def _build_path(configuration, binary) and then just ignore the configuration parameter here. 
> > 
> > However, I'm not real comfortable with ninja ignoring the configuration. That seems like it could cause bad things could happen and is unlike all of our other builds.
> 
> In ninja, the configuration is part of the gclient step.
> 
> I feel that whoever is using ninja right now should just symlink out/{Debug,Release} to ninja/.  It's not quite ready for prime time yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.