[Webkit-unassigned] [Bug 54937] Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54937


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rolandsteiner at chromium.org




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-22 18:31:28 PST ---
(In reply to comment #6)
> Something like this perhaps?
> ASSERT(start().isNull() || start().anchorType() == Position::PositionIsOffsetInAnchor);

No this wouldn't work.  Because start() could be before/after a node.  The whole point of this function is to figure out whether or not we're inside an input[type=password].  Position could be anywhere.

> Using containerNode to get something like shadow ancestor or document can be error prone since not all valid positions have a containerNode, i.e. before/after positions anchored to a shadow DOM's root element.

But this can't happen inside an input element because we always have div, and we should never have a position before/after this div as that would break all sorts of assumptions in other parts of the editing code.  In my opinion, we should refactor shadow DOM code so that we always have a document-like ShadowRootElement.  Roland would know where we are now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.