[Webkit-unassigned] [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54986


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83422|review?                     |review+
               Flag|                            |




--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-22 18:25:48 PST ---
(From update of attachment 83422)
View in context: https://bugs.webkit.org/attachment.cgi?id=83422&action=review

The patch looks good. r=me provided you all layout tests ran successfully.

> Source/WebCore/ChangeLog:11
> +        No tests. This is intended to simplify the transition to new Positions, not change behavior.

not "to" change behavior?

> Source/WebCore/dom/Position.h:97
> +        if (m_isLegacyEditingPosition || m_anchorType != PositionIsAfterAnchor)
> +            return m_offset;
> +        return offsetForPositionAfterAnchor();

Might be nice to special case position after node instead so that condition here matches the assertion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.