[Webkit-unassigned] [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 17:04:24 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54986





--- Comment #5 from Levi Weintraub <leviw at chromium.org>  2011-02-22 17:04:24 PST ---
(In reply to comment #4)
> (From update of attachment 83409 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83409&action=review
> 
> > Source/WebCore/dom/Position.cpp:153
> > +int Position::deprecatedEditingOffset() const
> > +{
> > +    // This should probably ASSERT(m_isLegacyEditingPosition);
> > +    return (m_isLegacyEditingPosition || m_anchorType != PositionIsAfterAnchor) ? m_offset : lastOffsetForEditing(m_anchorNode.get());
> > +}
> 
> Why we can't keep this function inline?  I'm afraid that making this function non-inline will have some performance impact.

See the first comment on this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list