[Webkit-unassigned] [Bug 54937] Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54937





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-22 17:03:27 PST ---
(From update of attachment 83273)
View in context: https://bugs.webkit.org/attachment.cgi?id=83273&action=review

>>>> Source/WebCore/editing/SelectionController.cpp:1442
>>>> +    Node* startNode = start().containerNode();
>>> 
>>> containerNode can be null here when there's still a valid anchorNode and shadow ancestor. I don't think this will ever be a problem for input tags, but this smacks of an assumption that could change.
>> 
>> That should be fine because we're only trying to figure out whether we're inside a input[type=password] or not.  If we ever had a position like before/after the shadow DOM's root element, we'll be in a trouble anyways.
> 
> Sounds like good rationale for an assert then :)

What kind of assertion are you talking about?  I can't do ASSERT(startNode) here because start() could be null.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.