[Webkit-unassigned] [Bug 55005] New: SegmentedString operator= always causes a malloc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55005

           Summary: SegmentedString operator= always causes a malloc
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: darin at apple.com, sam at webkit.org, abarth at webkit.org,
                    aestes at apple.com


SegmentedString operator= always causes a malloc

This is slowing down parsing due to:

#0    0x1007beb91 in WTF::fastMalloc at FastMalloc.cpp:3835
#1    0x10184fd29 in VectorBuffer [inlined] at Vector.h:288
#2    0x10184fd29 in VectorBuffer [inlined] at Vector.h:311
#3    0x10184fd29 in Deque [inlined] at Vector.h:363
#4    0x10184fd29 in Deque [inlined] at Deque.h:337
#5    0x10184fd29 in WTF::Deque<WebCore::SegmentedSubstring>::operator= at Deque.h:321
#6    0x10184fd29 in WebCore::SegmentedString::operator= at Vector.h:3835
#7    0x101176a8c in WebCore::SegmentedString::numberOfCharactersConsumed at SegmentedString.h:38
#8    0x101176a8c in WebCore::HTMLSourceTracker::start at HTMLSourceTracker.cpp:3835

The root of the problem seems to be that SegmentedString uses a Deque (m_substrings) which uses a Vector with inlineCapacity=0.

I'm investigating making that inlineCapacity=1 and see if the malloc goes away.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.