[Webkit-unassigned] [Bug 54912] Minimize calls to ubrk_setText()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54912





--- Comment #6 from mitz at webkit.org  2011-02-22 11:21:07 PST ---
(From update of attachment 83343)
View in context: https://bugs.webkit.org/attachment.cgi?id=83343&action=review

Looks good! A few coding style comments below.

> Source/WebCore/platform/text/TextBreakIterator.h:63
> +    LazyLineBreakIterator(const UChar* string = 0, int length = 0)

Are you using these default parameters? If not, please remove them.

> Source/WebCore/platform/text/TextBreakIterator.h:68
> +    { }
> +

WebKit style is to do
{
}

> Source/WebCore/platform/text/TextBreakIterator.h:84
> +    }
> +    void reset(const UChar* string, int length)

Missing newline here

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:81
> +        setUpIterator(createdLineBreakIterator,
> +            staticLineBreakIterator, UBRK_LINE, string, length);

No reason to split this across two lines.

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:94
> + {

Leading whitespace

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.