[Webkit-unassigned] [Bug 54585] [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54585





--- Comment #10 from Adam Klein <adamk at chromium.org>  2011-02-22 10:22:54 PST ---
(From update of attachment 82689)
View in context: https://bugs.webkit.org/attachment.cgi?id=82689&action=review

>> Source/WebCore/fileapi/DOMFileSystem.cpp:54
>>      , ActiveDOMObject(context, this)
> 
> It's too bad we end up with two pointers to the script execution context, but I don't see a way around it.

Yeah, given the way the type hierarchy works, I don't see a better way. I could just hold onto a ScriptOrigin*, but that strikes me as conceptually worse.

>> Source/WebCore/fileapi/EntryBase.cpp:59
>> +    StringBuilder uriBuilder;
> 
> nit: I would have just called this "result" or something.

Fixed, agreed this name is better. Wish StringBuilder was a bit more like the Java version and allowed me to chain.

>> Source/WebCore/fileapi/EntryBase.cpp:63
>> +    uriBuilder.append(m_fileSystem->asyncFileSystem()->type() == AsyncFileSystem::Temporary ? "temporary" : "persistent");
> 
> These should use the constants, but I guess that hasn't landed yet

Will use the constants once the other 54774 lands; for now I just want to avoid a merge conflict between the two patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.