[Webkit-unassigned] [Bug 54685] Remove flakiness from media/video-poster.html (in service of http://crbug.com/60845)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 22 08:40:17 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=54685
Eric Carlson <eric.carlson at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83241|review?, commit-queue? |review-
Flag| |
--- Comment #11 from Eric Carlson <eric.carlson at apple.com> 2011-02-22 08:40:17 PST ---
(From update of attachment 83241)
View in context: https://bugs.webkit.org/attachment.cgi?id=83241&action=review
Thanks for the quick response!
It looks like this diff is against r78778, not TOT, so I don't think the commit bot will work. Noted stylistic changes it would be good to have as long as this needs to be revised anyway.
> LayoutTests/media/video-poster.html:50
> + if (video.clientWidth == expectedWidth &&
> + video.clientHeight == expectedHeight) {
I don't think it helps readability to break the test into two lines
> LayoutTests/media/video-poster.html:53
> + callback();
> + return;
> + }
An early return when the rest of the function only has one line seems unnecessary, I think an "else" would be easier to follow.
> LayoutTests/media/video-poster.html:57
> + window.setTimeout(listenForWidthAndHeight, 20,
> + expectedWidth, expectedHeight, callback);
No need to break the function onto two lines.
> LayoutTests/media/video-poster.html:59
> +
As long as you are editing the file, can you kill this extra white-space?
> LayoutTests/media/video-poster.html:89
> + listenForWidthAndHeight(
> + currentPoster.width, currentPoster.height, testPoster);
No line break please.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list