[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48127





--- Comment #40 from Balazs Kelemen <kbalazs at webkit.org>  2011-02-22 05:46:43 PST ---
(In reply to comment #38)
> (From update of attachment 83298 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83298&action=review
> 
> Looks ok, but I have a few comments
> 
> > Source/WebCore/plugins/PluginPackage.cpp:42
> > +#if XP_UNIX
> > +#include "x11/X11PluginQuirks.h"
> > +#endif
> 
> for Qt we could check for X11. Q_WS_X11

I don't mind using that but we need to check XP_UNIX for GTK and others.
Some grep output:

GNUmakefile.am
168:# For the Gtk port we want to use XP_UNIX both in X11 and Mac
169-if !TARGET_WIN32
170-global_cppflags += \
171:    -DXP_UNIX
172-endif

Source/cmake/OptionsCommon.cmake-11-IF (WTF_OS_UNIX)
Source/cmake/OptionsCommon.cmake:12:    ADD_DEFINITIONS(-DXP_UNIX)
Source/cmake/OptionsCommon.cmake-13-ENDIF (WTF_OS_UNIX)

> 
> > Source/WebCore/plugins/x11/X11PluginQuirks.cpp:5
> > + * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
> > + * Copyright (C) 2008 Collabora Ltd. All rights reserved.
> > + * Copyright (C) 2009 Holger Hans Peter Freyther
> > + * Copyright (C) 2010 University of Szeged. All rights reserved.
> 
> Strange that there is no Nokia copyright

It is mostly copy-paste so I just copied the copyrights. Should I add Nokia? (Sounds strange to me.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.