[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48127





--- Comment #38 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-02-22 04:55:15 PST ---
(From update of attachment 83298)
View in context: https://bugs.webkit.org/attachment.cgi?id=83298&action=review

Looks ok, but I have a few comments

> Source/WebCore/plugins/PluginPackage.cpp:42
> +#if XP_UNIX
> +#include "x11/X11PluginQuirks.h"
> +#endif

for Qt we could check for X11. Q_WS_X11

> Source/WebCore/plugins/x11/X11PluginQuirks.cpp:5
> + * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
> + * Copyright (C) 2008 Collabora Ltd. All rights reserved.
> + * Copyright (C) 2009 Holger Hans Peter Freyther
> + * Copyright (C) 2010 University of Szeged. All rights reserved.

Strange that there is no Nokia copyright

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.