[Webkit-unassigned] [Bug 54538] symbol display <use> at wrong scale

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54538





--- Comment #9 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-02-22 03:23:21 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > 'this' is corresponding use element instead of direct referencing use element.
> > corresponding use element is not same as direct referencing use element in some cases.
> What you currently do is: initialize m_directUseElement to 0 in the constructor.
> Then you call setDirectUseElement(this) from SVGUseElement _or_ setDirectUseElement(target).
> So it's perfectly fine to use the same values as correspondingUseElement as default for directUseElement.
> This just saves to call setDirectUseElement(this) in one place.

If we initialize m_directUseElement to correspondingUseElement, we need to call setDirectUseElement(0) for instances which have no direct use element. This will be a lot of calls in for loop in buildInstanceTree(). So I think adding a parameter for direct use element in constructor and removing setDirectUseElement is more efficient. In this way, all callers should pass direct use element explicitly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.