[Webkit-unassigned] [Bug 54538] symbol display <use> at wrong scale

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54538





--- Comment #6 from Nikolas Zimmermann <zimmermann at kde.org>  2011-02-22 02:31:13 PST ---
(In reply to comment #5)
> > This is fine, as it's just debugging code.
> Can you make me clear about this comment?
Well, this code is not efficient, but it's not a problem, as it's only the dumpInstanceTree debug code, which is not compiled in by default, just wanted to leave a comment :-)

> > > Source/WebCore/svg/SVGUseElement.cpp:551
> > > +    m_targetElementInstance->setDirectUseElement(this);
> > 
> > I'd remove this line, and directly initialize m_directUseElement to 'this' in the SVGElementInstance constructor, by using the first constructor param, just like it's done for m_correspondingUseElement.
> OK. Will remove setDirectUseElement and add a parameter to constructor.
No need to add a parameter, the first param is already containing 'this'.

> > The corresponding ‘use’ element to which this SVGElementInstance object belongs. When ‘use’ elements are nested (e.g., a ‘use’ references another ‘use’ which references a graphics element such as a ‘rect’), then the correspondingUseElement is the outermost ‘use’ (i.e., the one which indirectly references the ‘rect’, not the one with the direct reference)."
> > 
> Yes, corresondingUseElement stays as is. This patch doesn't alter it except change its name from m_useElement to m_correspondingUseElement to make it more
> clear.
Great.

> 
> > Can you please extend the testcase, to check that the generated SVGElementInstance is just like SVG describes it here?
> 
> OK. Will add more test cases.
Looking forward to these...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.