[Webkit-unassigned] [Bug 54920] [chromium] WebWorkerBase::openFileSystem confuses clang's -Woverloaded-virtual

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54920





--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org>  2011-02-22 02:17:49 PST ---
(From update of attachment 83248)
View in context: https://bugs.webkit.org/attachment.cgi?id=83248&action=review

Thanks for cleaning up the confusing overloads and  messed-up half-way two sided patches.

> Source/WebKit/chromium/public/WebCommonWorkerClient.h:96
> +    virtual void openFileSystemForWorker(WebFileSystem::Type type, long long size, bool create, WebFileSystemCallbacks* callbacks)

Hmm I think actually what we want to leave here is the one WITHOUT the bool create flag.
The flag was added to WebFrameClient::openFileSystem mainly for devtools support, and we don't need such a flag in worker cases.
So can we just rename the method but leave the parameters as is?   (Or if you think the naming is ok we can just leave it as is, as I believe for WebCommonWorkerClient there're no worries for confused overloads.)

Again, thanks for cleaning up this and sorry for the mess.

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:220
> +        commonClient->openFileSystemForWorker(type, size, /*create=*/false, MainThreadFileSystemCallbacks::createLeakedPtr(bridge, mode));

As I commented above can we not add the 'create' flag?  (And if we add it it's got to be true).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.