[Webkit-unassigned] [Bug 54905] Remove global initializer in CookieStorageCFNet.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54905


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83219|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2011-02-21 15:03:19 PST ---
(From update of attachment 83219)
View in context: https://bugs.webkit.org/attachment.cgi?id=83219&action=review

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:61
> +    if (s_cookieStorage)
> +        CFRelease(s_cookieStorage);
> +
> +    CFRetain(cookieStorage);

The usual pattern is to put retain before release so things work properly if s_cookieStorage and cookieStorage happen to be the same object. You could do that here by just moving the CFRetain call up a couple lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.