[Webkit-unassigned] [Bug 54905] Remove global initializer in CookieStorageCFNet.cpp

Mon Feb 21 14:11:53 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54905

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83212|review?                     |review+
               Flag|                            |

--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-02-21 14:11:53 PST ---
(From update of attachment 83212)
View in context: https://bugs.webkit.org/attachment.cgi?id=83212&action=review

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:43
> -static RetainPtr<CFHTTPCookieStorageRef> s_cookieStorage;
> +static CFHTTPCookieStorageRef s_cookieStorage;

Do we need to init s_cookieStorage to 0 ?

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:70
> +        s_cookieStorage = wkCreatePrivateHTTPCookieStorage();

Should we assert that s_cookieStorage is 0 here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.