[Webkit-unassigned] [Bug 54585] [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54585


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82689|review?                     |review+
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2011-02-21 12:50:01 PST ---
(From update of attachment 82689)
View in context: https://bugs.webkit.org/attachment.cgi?id=82689&action=review

> Source/WebCore/fileapi/DOMFileSystem.cpp:54
> -    : DOMFileSystemBase(name, asyncFileSystem)
> +    : DOMFileSystemBase(context, name, asyncFileSystem)
>      , ActiveDOMObject(context, this)

It's too bad we end up with two pointers to the script execution context, but I don't see a way around it.

> Source/WebCore/fileapi/EntryBase.cpp:59
> +    StringBuilder uriBuilder;

nit: I would have just called this "result" or something.

> Source/WebCore/fileapi/EntryBase.cpp:63
> +    uriBuilder.append(m_fileSystem->asyncFileSystem()->type() == AsyncFileSystem::Temporary ? "temporary" : "persistent");

These should use the constants, but I guess that hasn't landed yet

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.