[Webkit-unassigned] [Bug 54888] Add regression test for clean shutdown during video playback.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54888





--- Comment #6 from Ami Fischman <fischman at chromium.org>  2011-02-21 12:44:40 PST ---
(From update of attachment 83175)
View in context: https://bugs.webkit.org/attachment.cgi?id=83175&action=review

>> LayoutTests/ChangeLog:6
>> +        This didn't always use to be the case (http://crbug.com/72730).
> 
> It would be good to have more information about why this test is necessary, I didn't understand what "clean shutdown during video playback" meant until I read the chromium bug.

Expanded changelog & in-test text.

>> LayoutTests/media/video-plays-past-end-of-test.html:3
>> +
> 
> I really like to have information about what a test does in the markup so someone opening the test manually can figure out what is happening without having to view source. As above, "clean shutdown during video playback" didn't explain it for me.

Done.
(I used an HTML comment instead b/c in non-dumpAsText tests, this kind of explanatory text is often the sole reason for the need for per-platform expectations, as antialiasing/hinting cause minute differences; I realize now I should take it up with a larger group than just my local team if I want a change to SOP in this area; but anyway it's irrelevant to this test b/c it's a dumpAsText test, anyway)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.