[Webkit-unassigned] [Bug 54888] Add regression test for clean shutdown during video playback.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54888


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83175|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Eric Carlson <eric.carlson at apple.com>  2011-02-21 11:32:59 PST ---
(From update of attachment 83175)
View in context: https://bugs.webkit.org/attachment.cgi?id=83175&action=review

Marking r- for the minor changes noted.

> LayoutTests/ChangeLog:6
> +        Add regression test for clean shutdown during video playback.
> +        This didn't always use to be the case (http://crbug.com/72730).

It would be good to have more information about why this test is necessary, I didn't understand what "clean shutdown during video playback" meant until I read the chromium bug.

> LayoutTests/media/video-plays-past-end-of-test.html:3
> +<!-- This test intentionally lets the video keep playing past endTest() to
> +     ensure that shutdown is clean. -->
> +

I really like to have information about what a test does in the markup so someone opening the test manually can figure out what is happening without having to view source. As above, "clean shutdown during video playback" didn't explain it for me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.