[Webkit-unassigned] [Bug 54870] [GStreamer] GRefPtr support for GstElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54870


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83150|review?                     |review-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-02-21 08:22:28 PST ---
(From update of attachment 83150)
View in context: https://bugs.webkit.org/attachment.cgi?id=83150&action=review

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:32
> +template <> void derefGPtr<GstElement>(GstElement* ptr)
> +{
> +    if (ptr)
> +        gst_object_unref(ptr);
> +}

There should also be a specialization for refGPtr even if it's currently unused with your changes. If that's not there g_object_ref will be used when you assign a GRefPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.