[Webkit-unassigned] [Bug 54876] Web Inspector: [Text editor] Bug in the highlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54876


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83155|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2011-02-21 06:46:52 PST ---
(From update of attachment 83155)
View in context: https://bugs.webkit.org/attachment.cgi?id=83155&action=review

> LayoutTests/inspector/editor/highlighter-bugs-test-expected.txt:3
> +doTestForBug1()

Bug1?

> LayoutTests/inspector/editor/highlighter-bugs-test-expected.txt:7
> +    0 : {

Could you use a more dense format? (Look at syntax-highlight-* tests for inspiration).

> LayoutTests/inspector/editor/highlighter-bugs-test.html:14
> +    window.setTimeout = function(func) {

Bad things may happen. You should either use sniffers (InspectorTest.addSniffer) or extend highlighter API (add "immediately" optional parameter) to workaround asynchronous operations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.