[Webkit-unassigned] [Bug 54822] Web Inspector: generate protocol documentation based on IDL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54822


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83092|review?                     |review+
               Flag|                            |




--- Comment #7 from Yury Semikhatsky <yurys at chromium.org>  2011-02-21 02:57:14 PST ---
(From update of attachment 83092)
View in context: https://bugs.webkit.org/attachment.cgi?id=83092&action=review

>> Source/WebCore/inspector/CodeGeneratorInspector.pm:394
>> +}
> 
> Please use inline text. It is significantly increasing readability.

I second this comment.

> Source/WebCore/inspector/CodeGeneratorInspector.pm:521
> +        push(@lines, "    command: \"${functionName}\"");

This line can be pulled out  of the if block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.