[Webkit-unassigned] [Bug 54856] New: Web Inspector: Web Inspector protocol metabug.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54856

           Summary: Web Inspector: Web Inspector protocol metabug.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pfeldman at chromium.org
                CC: timothy at apple.com, rik at webkit.org, keishi at webkit.org,
                    pmuellr at yahoo.com, joepeck at webkit.org,
                    pfeldman at chromium.org, yurys at chromium.org,
                    bweinstein at apple.com, apavlov at chromium.org,
                    loislo at chromium.org


Each entry here should be fixed as a bug. I won't be creating bugs right now because there are too many:

Raw message format:
For following items see description in https://docs.google.com/a/google.com/document/edit?id=1d_N-OIb3UztuC-_g0piXsIIdp89HnMcDk-uSQ8uamW4&hl=en&authkey=CIf48O4J&pli=1#
- Each event and command request should have "seq" number, each command response should have "seq" and "request_seq". Rationale: we should be able to tell that the message was lost.
- Each command response should have boolean success and string error message as in protocol above.
- All messages should explicitly state their type (request, response, event)
- Response data should live in attribute "body"
- Rename [notify] into [event] in the IDL
- We should never use Value in the protocol. Should be either Array or Object (or primitive number)
- Some parameters should be marked as optional with default values:
        Console::evaluate(in String expression, in String objectGroup, in [optional, default=0] number callFrameId, in [optional, default=true] boolean includeCommandLineAPI, out [typeRef=objectRef] Object result);
- All events should use notification wording, not command wording: addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc.

Domain-specific changes:
[Inspector]
- Move setUserAgentOverride to the Network agent
- Move addNodesToSearchResult to DOMAgent. Abstract agent from performing UI search into executing asynchronous text search managed from the front-end.
- Move start/stopTimelineProfiler to the Timeline agent
- Same for debugging and profiling
- disconnectFromBackend should vanish. We should not ask front-end to initiate disconnect.

[Runtime]
- Merge Runtime agent into Console agent (all it really does is interacting with console)
- For all Runtime messages, out parameter should be more specific (Object, Array, number)
- Worker messages should be moved to worker agent

[InjectedScript]
- Agent should be removed

[DOM]
- Should not push nodes into front-end, should rather request nodes

[CSS]
- All out parameters are broken (Values)

[Timeline]
- Remove timelineProfilerWasStarted / Stopped in favor of start/stop callbacks. This has WebKit implications that need to be resolved.

[Debugger]
- Same for debuggerWasEnabled / debuggerWasDisabled
- activateBreakpoints/deactivateBreakpoints -> setBreakpointsActive(bool)
- We can merge setJavaScriptBreakpoint and setJavaScriptBreakpointBySourceId once protocol allows optional parameters
- We might want to merge evaluateOnCallFrame and getCompletionsOnCallFrame once optional parameters are allowed
- Move workers into separate agent

[BrowserDebugger]
- setAllBrowserBreakpoints should be further split

[Profiler]
- Needs major review

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.