[Webkit-unassigned] [Bug 23526] clipToImageBuffer() for all platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23526





--- Comment #27 from Dirk Schulze <krit at webkit.org>  2011-02-20 10:50:58 PST ---
(In reply to comment #26)
> (In reply to comment #25)
> > I've uploaded a completed patch for this issue. It does two things:
> > 
> > 1. Instead of pushing two groups to emulate the image clip, it pushes one (to isolate the mask) and then calls cairo_mask_surface during restorePlatformState.
> > 
> > 2. Cairo does not composite with the previous group when you push a group. To deal with this problem, I blit the contents of the previous group onto the new group after pushing it. This produces the correct rendering with Andrei's test case.
> 
> Did you run pixel tests on LayoutTests/svg/clip-path/? Or even better LayoutTests/svg/ in general?

Oops. Forget this comment. Saw the results in your patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.