[Webkit-unassigned] [Bug 54822] Web Inspector: generate protocol documentation based on IDL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54822





--- Comment #3 from Ilya Tikhonovsky <loislo at chromium.org>  2011-02-20 07:54:35 PST ---
(From update of attachment 83092)
View in context: https://bugs.webkit.org/attachment.cgi?id=83092&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:394
> +{
> +    my $interface = shift;
> +    my $function = shift;
> +
> +    my $functionName = $function->signature->name;
> +    my $domain = $interface->name;
> +
> +    my @argsFiltered = grep($_->direction eq "out", @{$function->parameters});
> +
> +    my @lines;
> +    push(@lines, "<h4>" . $interface->name . "." . ${functionName} . "</h4>");
> +    my $doc = $function->signature->extendedAttributes->{"doc"};
> +    if ($doc) {
> +        push(@lines, $doc);
> +    }
> +
> +    push(@lines, "<pre style='background: lightGrey; padding: 10px'>");
> +    push(@lines, "{");
> +    push(@lines, "    seq: <number>,");
> +    push(@lines, "    type: \"event\",");
> +    push(@lines, "    domain: \"$domain\",");
> +    if (scalar(@argsFiltered)) {
> +        push(@lines, "    event: \"${functionName}\",");
> +        push(@lines, "    data: {");
> +        my @parameters;
> +        foreach my $parameter (@argsFiltered) {
> +            push(@parameters, "        " . parameterDocLine($parameter));
> +        }
> +        push(@lines, join(",\n", @parameters));
> +        push(@lines, "    }");
> +    } else {
> +        push(@lines, "    event: \"${functionName}\"");
> +    }
> +    push(@lines, "}");
> +    push(@lines, "</pre>");
> +    push(@documentationLines, @lines);
> +}

Please use inline text. It is significantly increasing readability.

> Source/WebCore/inspector/CodeGeneratorInspector.pm:546
> +

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.