[Webkit-unassigned] [Bug 54687] Invalid label can be added into backtrack when building with armcc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54687





--- Comment #11 from Eric Seidel <eric at webkit.org>  2011-02-19 21:52:53 PST ---
(In reply to comment #10)
> This patch makes no sense to me. "int" is always signed in C++.
> 
> Eric, I don't understand why this has been given green light. There is no explanation of what specific problem this patch fixes, and according to comment 4, even regression tests haven't been run!

The patch seemed reasonable to me.  Yes, ideally there should have been a link to the armcc bug (as I requested in the other bug he filed on this subject).

He states in comment 0 that according to his (I assume yong is a he?) reading of the c++ spec ints in bitfields are unspecified as to their sign.  I've not confirmed this.  But I could believe that armcc might have such a bug.

The cq obviously ran the regression tests. :)

Feel free to roll out the change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.