[Webkit-unassigned] [Bug 50116] On platforms other than Mac, right clicking anywhere discards the selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50116





--- Comment #34 from Pierre Rossi <pierre.rossi at gmail.com>  2011-02-19 12:09:43 PST ---
(In reply to comment #33)

> > WebCore/page/EventHandler.cpp:404
> >      } else
> >          newSelection = VisibleSelection(visiblePos);
> > -    
> > -    if (m_frame->selection()->shouldChangeSelection(newSelection))
> > +
> > +    const bool shouldReplaceSelection = (m_frame->editor()->behavior().shouldDiscardCurrentSelectionOnRightClick() || event.event().button() == LeftButton);
> > +    if (shouldReplaceSelection && m_frame->selection()->shouldChangeSelection(newSelection))
> 
> It seems like we should avoid setting selection only if the above else statement was executed.  i.e. we should set selection when selection is extended even if the editing behavior was Linux, and the right button is pressed.

I don't like this idea that much, as it would mean the context menu pops out as the selection gets modified, this feels confusing to me (yes, apparently that's the way it works on Mac...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.