[Webkit-unassigned] [Bug 54361] [Chromium] Issue 50685: Move CC icons to chrome/common and implement loadPlatformResource in RendererWebKitClientImpl.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54361


David Holloway <dhollowa at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dhollowa at chromium.org




--- Comment #16 from David Holloway <dhollowa at chromium.org>  2011-02-18 14:48:21 PST ---
It appears that:

Image::loadPlatformResource calls
PlatformBridge::loadPlatformImageResource which calls
WebKitClient::loadResource

So we end up at the same place via a different route.

There's no advantage to adding a new method to the WebKitClient interface.

There is little (if any) advantage to taking the Image::loadPlatformResource route.

So I would lobby that we abandon this patch.  However it would be very nice to rename the resources on the Chrome side to be chrome/common/resources/cc_amex.png, chrome/common/resources/cc_generic.png, etc.  But let's discuss that in http://codereview.chromium.org/6516002/.


(In reply to comment #15)
> (In reply to comment #14)
> > Ok, so do you agree to change Image::loadPlatformResource()?
> 
> Could you please explain what change exactly is needed and why?  That might be easiest to do just by uploading the diff and perhaps pointing out the relevant part of it.
> 
> Again, I do not know this corner of the code at all well, but it looks to me like we should be able to just use it as-is and still be able to move the image resources, which is the real goal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.