[Webkit-unassigned] [Bug 54491] [cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails

Fri Feb 18 14:29:08 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54491

--- Comment #11 from Zan Dobersek <zandobersek at gmail.com>  2011-02-18 14:29:08 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 82972 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=82972&action=review
> > It's shorter, and it works also.
> > So, there are a few options, what to go with?
> 
> I think we should go for two things in this section: execution speed and clarity. If this is not a particularly hot function, we should go mostly for clarity. If this is a hot function we should maximize execution speed and if there are some particularly low hanging speedups we can apply, we should be sure to comment them thorougly.

I've ran the three options through a benchmark. The four if statements proved to be the fastest, executing in half the time than the other two options.

They also offer the most clarity, so I'll be updating the patch to use this option and uploading it tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.