[Webkit-unassigned] [Bug 54680] Remove Invalid ASSERT in SubframeLoader::requestObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54680





--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2011-02-18 14:17:20 PST ---
Actually, this ASSERT would have helped catch situations like the following:
<http://webkit.org/b/47550> For WebKit plug-ins, beforeload can be called recursively (esp. with AdBlock style extensions)

I see now that I was using an older version of WebKit that allowed this type of recursion
in creating Renders during a beforeload event. I think it might be worth keeping
this ASSERT in, but adding a comment to explain that if this ASSERT happens, it
may be another case of an unexpected renderer for an HTMLPluginElement.
Something like:

    // If the render is null, this HTMLPlugInImageElement likely has a fallback renderer
    // Why there is a fallback renderer? Does this it makes sense that there is one?
    ASSERT(renderer);

Worth adding?

I know the path I just explained still exists, but it doesn't seem to happen in practice,
and the case where I saw it was with an outdated WebKit. There is already a FIXME
comment to remove renderers from SubframeLoader::requestObject anyways.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.