[Webkit-unassigned] [Bug 54361] [Chromium] Issue 50685: Move CC icons to chrome/common and implement loadPlatformResource in RendererWebKitClientImpl.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 14:09:01 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54361





--- Comment #14 from Naoki Takano <takano.naoki at gmail.com>  2011-02-18 14:09:01 PST ---
Ok, so do you agree to change Image::loadPlatformResource()?

(In reply to comment #13)
> (In reply to comment #12)
> > Ilya,
> > 
> > I agree we might not need to change WebKit if if we just move the resource.
> > 
> > 
> > But, again, I already asked James here
> > 
> > http://code.google.com/p/chromium/issues/detail?id=50685
> > 
> > >2, does "loadPlatformResource" mean "loadResource"? Or do we have to declare another function different from "loadResouce"? And should we use "loadPlatformResource" for icon loading and change the calling in WebKit source code?
> > 
> > 
> > And he replied,
> > 
> > >re: loadPlatformResource. No, it means loadPlatformResource. ack-grep is your friend.
> > 
> > I don't know his intention, but I guess he wanted to separate the function according to the resource location.
> 
> It sounds like he meant Image::loadPlatformResource():
> 
> "When I said use loadPlatformResource() in the TODO, I mean Image::loadPlatformResource()."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list