[Webkit-unassigned] [Bug 52280] [GStreamer] support in mac video fullscreen controller

Fri Feb 18 12:32:01 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52280

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78664|review?                     |review-
               Flag|                            |

--- Comment #5 from Eric Seidel <eric at webkit.org>  2011-02-18 12:32:01 PST ---
(From update of attachment 78664)
View in context: https://bugs.webkit.org/attachment.cgi?id=78664&action=review

Seems we could use functions to abstract away some of this, no?

> WebKit/mac/WebView/WebVideoFullscreenController.mm:117
> +    [window setHasShadow:YES]; // This is nicer with a shadow.
> +    [window setLevel:NSPopUpMenuWindowLevel-1];

Seems this is shared with the QT path, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.