[Webkit-unassigned] [Bug 50521] [Qt] Improper rendering of <button> tag when it contains a <br>

Fri Feb 18 11:50:53 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50521

Dawit A. <adawit at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82989|                            |review?
               Flag|                            |

--- Comment #9 from Dawit A. <adawit at kde.org>  2011-02-18 11:50:53 PST ---
Created an attachment (id=82989)
 --> (https://bugs.webkit.org/attachment.cgi?id=82989&action=review)
proposed patch...

Do not hard code the width/height of the render style in RenderThemeQt::computeSizeBasedOnStyle. Instead set the calculated values as minimum width and height values.

Set the original values of the bottom and top margin variables in RenderThemeQt::setButtonPadding to the same value as the right and left ones. No idea why one is set to 1 and the other to 0.

No idea what kind of impact this has on the mobile platforms with their qt_mobile_theme, but these changes definitely fix the problem with multi-line text buttons on Linux desktops.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.