[Webkit-unassigned] [Bug 6503] content property doesn't support quotes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=6503


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82985|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #40 from Dave Hyatt <hyatt at apple.com>  2011-02-18 11:32:44 PST ---
(From update of attachment 82985)
View in context: https://bugs.webkit.org/attachment.cgi?id=82985&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:4729
> +    case CSSPropertyQuotes:
> +        if (isInherit) {
> +            if (m_parentStyle)
> +                m_style->setQuotes(m_parentStyle->quotes());
> +            return;
> +        }

Still don't see the isInitial case here for handling the initial value.  You should probably make a test case that tests -webkit-initial explicitly, since this isn't being covered.  Put an object with quotes:-webkit-initial inside an object with quotes:none to see the problem.  If I'm understanding how you represent the initial value correctly (with a null pointer), then all your isInitial case needs to do is m_style->setQuotes(0).

> Source/WebCore/rendering/RenderQuote.cpp:245
> +    ASSERT(m_depth != UNKNOWN_DEPTH);
> +     const QuotesData* quotes = style()->quotes();
> +     if (!quotes)
> +         quotes = defaultQuotes(this);

Some funny indenting here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.