[Webkit-unassigned] [Bug 54491] [cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54491





--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2011-02-18 10:27:59 PST ---
(From update of attachment 82972)
View in context: https://bugs.webkit.org/attachment.cgi?id=82972&action=review

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:771
> +    double rwidth = round(width);
> +    double rheight = round(height);
> +    width = !rwidth ? (!width ? 0 : (width > 0 ? 1 : -1)) : rwidth;
> +    height = !rheight ? (!height ? 0 : (height > 0 ? 1 : -1)) : rheight;

Is it okay to simply write this as:
if (width < 0 && width > -1)
    width = -1;
if (width > 0 && width < 1)
    width = 1;
if (height < 0 && height > -1)
    height = -1;
if (height > 0 && height < 1)
    height = 1;

?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.