[Webkit-unassigned] [Bug 54688] ThreadableLoaderClient needs willSendRequest method.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54688





--- Comment #10 from David Levin <levin at chromium.org>  2011-02-18 07:46:05 PST ---
(In reply to comment #9)
> You made me think: If I took out the implementation of willSendRequest in WorkerThreadableLoader that attempts the asynchronous call and just made it a no-op, wouldn't that be the same thing?

But then you'd have this method in ThreadableLoaderClient which doesn't work (for the worker case).

btw, I thought a bit more about why I didn't like the adapter pattern in this case:
1. It adds another level of virtuals to go through.
2. It adds another class that people have to understand and maintain.

On the plus side 
1. It allows for more flexibility. (But that flexibility is only needed for one method.)
2. No need to upcast (and the isDocumentThreadableLoaderClient method could go away).

At this point I feel like the negatives out weight the positives.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.