[Webkit-unassigned] [Bug 54661] Web Inspector: [Text editor] Optimize editing updates in main panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54661


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82937|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2011-02-18 02:46:53 PST ---
(From update of attachment 82937)
View in context: https://bugs.webkit.org/attachment.cgi?id=82937&action=review

It looks sane, but I am a bit concerned with the code bloat. Can we introduce new structures / abstractions to keep the code in a readable state?

> Source/WebCore/inspector/front-end/TextViewer.js:44
> +    this._mainPanel = new WebInspector.TextEditorMainPanel(this._textModel, url, syncScrollListener, syncDecorationsForLineListener, enterTextChangeMode, exitTextChangeMode);

6 parameters in the constructor makes it look like a bad design.

> Source/WebCore/inspector/front-end/TextViewer.js:167
> +        // FIXME: UPDATE GUTTER SMARTLY!

No need to shout :)

> Source/WebCore/inspector/front-end/TextViewer.js:203
> +        var mainChunk = this._mainPanel.chunkForLine(lineNumber);

It sounds like main/gutterChunk separation starts hitting us (code bloat)

> Source/WebCore/inspector/front-end/TextViewer.js:773
> +    _markSkippedPaintLines: function(startLine, endLine)

What is "skipped line" and why do we mark it?

> Source/WebCore/inspector/front-end/TextViewer.js:1199
> +        // Update the chunks in range: firstChunkNumber <= index <= lastChunkNumber

Can this method receive only ranges?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.