[Webkit-unassigned] [Bug 53908] Get rid of code which writes test results from test_type/* classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53908





--- Comment #10 from Hayato Ito <hayato at chromium.org>  2011-02-17 19:03:52 PST ---
(From update of attachment 82775)
View in context: https://bugs.webkit.org/attachment.cgi?id=82775&action=review

>> Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:153
>> +    def write_text_diff(self, actual_text, expected_text):
> 
> Unlike the other methods, write_text_diff() and write_diff_image() are actually doing the diffs as well as writing them. They should probably be renamed, and I'm not sure if they even belong in this module as opposed to being in the caller (or elsewhere). But, I'm keen to see this patch land so we can make progress, so as long as all of the tests pass this is fine for now. Maybe add a FIXME and at least rename them?
> 
> LGTM otherwise.

Thank you. I've renamed two functions. The two functions are now 'create_text_diff_and_write_result' and 'create_image_diff_and_write_result'.
I've added a FIXME as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.