[Webkit-unassigned] [Bug 54658] [gtk] Failing collinear arcTo canvas tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54658


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82798|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-02-17 15:34:53 PST ---
(From update of attachment 82798)
View in context: https://bugs.webkit.org/attachment.cgi?id=82798&action=review

This is great! We want to make the if statement a little clearer below.

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:187
> +        || !(p0.x() * (p1.y() - p2.y()) + p1.x() * (p2.y() - p0.y()) + p2.x() * (p0.y() - p1.y()))) {

Please split out the area calculation to a static inline method called something like areaOfTriangleFormedByPoints.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.