[Webkit-unassigned] [Bug 54517] Ensure loading has stopped in HistoryController::goToItem

Thu Feb 17 14:13:53 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54517

--- Comment #7 from Charles Reis <creis at chromium.org>  2011-02-17 14:13:53 PST ---
(In reply to comment #6)
> Created an attachment (id=82860)
 --> (https://bugs.webkit.org/attachment.cgi?id=82860&action=review) [details]
> Patch

Here's a draft of what I mentioned in comment 5.

The main drawback is the need to handle Chromium's chrome-back-forward://go URLs for history.back() and history.forward().  We want to avoid stopping all loaders for those, since they get translated to a normal URL and then pass through Page::goToItem again.

This patch handles that, although it hard-codes the protocol rather than getting it from BackForwardListChromium.h.  (That would take a lot of ugly plumbing to get to here, probably via PlatformBridge).  I can change that if necessary.

I also removed the assert in HistoryController, because it would need similar exceptions for same document navigations and the chrome-back-forward scheme.  Maybe we can abstract all that into a function and keep the assert, though I'm not sure it's necessary now that we have a layout test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.