[Webkit-unassigned] [Bug 54680] New: Remove Invalid ASSERT in SubframeLoader::requestObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54680

           Summary: Remove Invalid ASSERT in SubframeLoader::requestObject
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org


SubframeLoader::requestObject:

    // FIXME: None of this code should use renderers!
    RenderEmbeddedObject* renderer = ownerElement->renderEmbeddedObject();
    if (!renderer)
        return false;

renderEmbeddedObject may return 0 when the ownerElement is not an
isEmbeddedObject, which may be the case if has fallback content.
See HTMLPlugInImageElement::createRenderer, and the HTMLObjectElement
subclass.

This ASSERT is unnecessary. Also, there is no change since the condition is
checked immediately afterwards. It can happen when an HTMLObjectElement
(a subclass) is passed in as the HTMLPlugInImageElement parameter. In
release builds this would act correctly and return, in which case the
HTMLObjectElement will render its fallback content (see
HTMLObjectElement::updateWidget).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.