[Webkit-unassigned] [Bug 49154] patches uploaded from git (using webkit-patch) do not include moved files

Thu Feb 17 08:56:04 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=49154

--- Comment #5 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-02-17 08:56:04 PST ---
(In reply to comment #4)
> We seem to run into this a lot, but I'm not sure I have good suggestions as to how to fix.

git detects renames through content only.  Is the real issue that committing the patch back to svn (via "git svn dcommit") doesn't represent the moved file like it would if "svn mv" were used?  If so, you may want to add this to the .git/config being used on the commit queue bots:

[diff]
    renames = true

If the bots are using an svn repo (not a git repo), then this issue becomes harder (unless everyone uses -M to make their patches so git includes "rename" metadata near the top of the patch.

This is completely orthogonal, but this should also be set (so that empty directories aren't left in svn by the bots):

[svn]
    rmdir = true

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.