[Webkit-unassigned] [Bug 54663] New: Stop using RenderThemeSafari when running regression tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 17 08:02:25 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54663

           Summary: Stop using RenderThemeSafari when running regression
                    tests
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Keywords: NeedsRadar, PlatformOnly
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: sfalken at apple.com, lforschler at apple.com


DumpRenderTree and WebKitTestRunner use RenderThemeSafari instead of RenderThemeWin. This is good for sharing results with Mac, but bad for testing the code that actually runs on users machines. It's also a maintenance burden; as new form controls are added, support for them needs to be added to RenderThemeSafari, even though users will never see that version of the form control! (E.g., bug 48690, bug 54662)

We should probably switch from using RenderThemeSafari to using RenderThemeWin when running regression tests. Unfortunately this will mean having more Windows-specific results. But it's just silly not to be testing code that users actually use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list