[Webkit-unassigned] [Bug 54627] [GStreamer] URI queries support in webkitwebsrc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54627


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82777|review?                     |review-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-02-17 07:36:15 PST ---
(From update of attachment 82777)
View in context: https://bugs.webkit.org/attachment.cgi?id=82777&action=review

Thanks for your contribution! Please consider the following review comments. This patch is only a few changes from an r+.

> WebCore/ChangeLog:10
> +        [GStreamer] URI queries support in webkitwebsrc
> +        https://bugs.webkit.org/show_bug.cgi?id=54627
> +
> +        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
> +        (webkit_web_src_init):
> +        (webKitWebSrcQuery):

Do you mind explaining a bit what this adds? Those familiar with Gstreamer will understand what sry query support means, but not the majority of the people skimming the ChangeLog.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:120
> +static gboolean webKitWebSrcQuery(GstPad * pad, GstQuery * query);

No spaces before the asterisks here.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:493
> +
> +static gboolean webKitWebSrcQuery(GstPad * pad, GstQuery * query)
> +{
> +    WebKitWebSrc * src = WEBKIT_WEB_SRC(gst_pad_get_parent_element(pad));

Ditto.

> WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:494
> +    gboolean ret;

Normally we don't abbreviate variable names in WebKit, so perhaps something like "success"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.