[Webkit-unassigned] [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51450


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82783|review?                     |review-
               Flag|                            |




--- Comment #20 from Kent Tamura <tkent at chromium.org>  2011-02-17 04:23:59 PST ---
(From update of attachment 82783)
View in context: https://bugs.webkit.org/attachment.cgi?id=82783&action=review

Some comments for small issues.

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:620
> +        updatedFamilyName = String(L"@") + String(family);

I think you don't need to do String(L"@").  Just '"@" + String(family)' should work.

> Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:82
> +    String newMName;

This should be "newName" because this variable is not a member of the class, so m makes no sense.

> Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:84
> +        newMName = String(L"@") + m_name.charactersWithNullTermination();

.charactersWithNullTermination() is not needed here.  This should be just 'newName = "@" + m_name;'

> Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:86
> +        newMName = m_name.charactersWithNullTermination();

.charactersWithNullTermination() is not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.