[Webkit-unassigned] [Bug 50126] Fallback content in canvas element not focusable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50126


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msanchez at igalia.com




--- Comment #21 from Mario Sanchez Prada <msanchez at igalia.com>  2011-02-17 01:39:52 PST ---
In LayoutTests/accessibility/canvas-fallback-content.html:

[...]
+            var fallback = document.getElementById("fallback");
+            fallback.focus();
+
+            var accessibilityFocusedElement = accessibilityController.focusedElement;
+            
+            var pattern = "AXRole: AXCheckBox";
+            if (document.activeElement.id == "fallback" &&
+                accessibilityController.focusedElement.allAttributes().indexOf(pattern) != -1) {
+                 result.innerText += "Test passed\n";
+            }
+            else {
+                 result.innerText += "Test failed\n" + fallbackElement.allAttributes();
+            }

[...]


Shouldn't the test use 'accessibilityFocusedElement' instead of 'fallbackElement' in the 'else' branch?

The GTK bots are entering in the 'else' branch and printing the following failure in the output:

--- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/accessibility/canvas-fallback-content-expected.txt    2011-02-16 22:06:01.629666022 -0800
+++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/accessibility/canvas-fallback-content-actual.txt    2011-02-16 22:06:01.629666022 -0800
@@ -1,3 +1,3 @@
+CONSOLE MESSAGE: line 41: ReferenceError: Can't find variable: fallbackElement

-Test passed

(see http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r78789%20(13902)/accessibility/canvas-fallback-content-diffs.txt)


Another doubt I have is whether we could use 'accessibilityFocusedElement' instead of calling  'accessibilityController.focusedElement' again in the second part of the AND in the if condition. Guess so, but not sure whether perhaps there's a good reason for that. Just wondering.

I didn't file a bug for these issues since I'd like to get some confirmation from you first, just to confirm I'm right.


In the other hand, another issue is why the Gtk port enters that 'else' branch, and that's what I'll work on right away. In the meanwhile, I will skip the test in the GTK port, since even if we fixed that variable name the GTK bots would keep the test failing because execution would enter through the else branch anyway...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.