[Webkit-unassigned] [Bug 48510] [GTK] Implement WebEventFactory, WebErrors classes for WebKit2

Thu Feb 17 01:29:12 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=48510

--- Comment #28 from Alejandro G. Castro <alex at igalia.com>  2011-02-17 01:29:12 PST ---
(In reply to comment #27)
> (From update of attachment 82715 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82715&action=review
> 
> Sorry. There were many things that I missed in my previous review. Below are some suggestions.
> 

No worries :), I was thinking that maybe we should apply other solution to this code, when you added the first comments improving the parts of the code that comes from webkit1 (PlatformMouseEvent, PlatformKeyboardEvent, etc.) it started to feel weird that we do not fix the code there. Initially I discarded it because creating a object just to create another one does not seem a good option (I guess that was the idea of the first implementation of this patch considering other ports are also copying the code) but I now think improving the code here a leaving the other code duplicated there seems worse.

So I'm going to try that option and check what we could have, in that case we can open new bugs improving the old code and add patches there. Does this solution sound good?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.